ReplayMemory to use deque instead of list #842
Conversation
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit 989373b https://deploy-preview-842--pytorch-tutorials-preview.netlify.app |
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Hi @PatrikHolopainen! Can you sign the CLA agreement so that I can merge the pull request? Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
…ode. (pytorch#842) Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Changed the ReplayMemory class to use a deque for self.memory instead of a list, as deque has the same functions but also a builti-in maxlen keyword argument, that pretty much does the entire "cyclic-buffer" thing.